Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing tests TestAccBigQueryJob_bigqueryJobCopy* #10520

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

wj-chen
Copy link
Member

@wj-chen wj-chen commented Apr 24, 2024

Fixes hashicorp/terraform-provider-google#17892.

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from melinath April 24, 2024 15:13
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 20 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 20 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 115
Passed tests: 104
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages
  • bigquery

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obada-ab
Copy link
Contributor

@wj-chen can you add release notes

@wj-chen
Copy link
Member Author

wj-chen commented Apr 26, 2024

@wj-chen can you add release notes

I set "release-note:none" since this is not a user-facing change.

@melinath melinath merged commit a63881a into GoogleCloudPlatform:main Apr 26, 2024
13 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccBigQueryJob_bigqueryJobCopy*
4 participants